-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: improve howto_release.md #5170
base: main
Are you sure you want to change the base?
Conversation
This PR aims to improve the (complex) release procedure: - re-order creation and use of variables - more use of VERSION variable to avoid manual copy-pasting - propagate the correct VERSION number throughout the procedure
Note: I have tested the updated procedure with the new GRASS GIS 8.4.1 release. |
Another question: in line 435 we have "For final releases only, go to Zenodo and get a Markdown badge for the release which Zenodo creates with a DOI for the published release." ... and then what? For now I have added the badge to the release notes. |
The overall tag list looks okay: https://hub.docker.com/r/osgeo/grass-gis/tags Seems the "latest" magic fails? Perhaps something for a separate issue (as docker is not part of this document)? |
That's why I fixed it in #5128, as it was hardcoded to only do something with 8.3/releasebranch_8_3. After suggestion to backport it for helping this release, it was considered not needed and chosen to not backport it. So it needs to be tagged manually as the workflow that would do it is not on that branch. |
I believe we didn't talk about the same thing :-( |
I tried to be clear in https://discourse.osgeo.org/t/re-release-planning-grass-gis-8-4-1/112698/15 https://discourse.osgeo.org/t/re-release-planning-grass-gis-8-4-1/112698/22 |
I would do the same! |
@@ -261,7 +271,7 @@ Eventually, commit with the suggested commit message and push, e.g.: | |||
```bash | |||
git show | |||
eval $(./utils/update_version.py status --bash) | |||
git commit include/VERSION -m "version: Back to $VERSION" | |||
git commit include/VERSION -m "version: Start $VERSION" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then let's solve it with a different variable.
Having "..."
must be avoided - we want automation here and not manual copy-pasting by a (often tired) release manager :-) Manual copy-pasting is error-prone since the release procedure takes several hours in which the release manager does other tasks in parallel.
This PR aims to improve the (complex) release procedure:
TODO:
gh run list...
(see below)